Skip to content

Commit

Permalink
docs: 💡 removed old todos
Browse files Browse the repository at this point in the history
  • Loading branch information
arctic-hen7 committed Aug 22, 2021
1 parent 51284a8 commit 9464ee5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion packages/perseus/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ pub enum ErrorCause {
Server(Option<u16>),
}

// TODO disclose what information may be revealed over the network through these errors in docs
// The `error_chain` setup for the whole crate
error_chain! {
// The custom errors for this crate (very broad)
Expand Down
2 changes: 0 additions & 2 deletions packages/perseus/src/shell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,9 @@ pub fn app_shell(
Err(err) => panic!("page data couldn't be serialized: '{}'", err)
};
},
// TODO NotFound
None => error_pages.render_page(&asset_url, &404, "page not found", &container),
},
Err(err) => match err.kind() {
// TODO NotOk
ErrorKind::AssetNotOk(url, status, err) => error_pages.render_page(url, status, err, &container),
// No other errors should be returned
_ => panic!("expected 'AssetNotOk' error, found other unacceptable error")
Expand Down

0 comments on commit 9464ee5

Please sign in to comment.