Fix only last duplicate link item processed when using host specific option #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "hosts" option is now defined as dictionary to allow multiple host-specific definitions without adding (mutliple) duplicate link items to the snowblock configuration file. The loop checks if the configured hosts matching the name of the current host, logs if a entry has been skipped and sets the correct path if the a marching host has been found. The bug occured because the builtin Python dictionary only allows unique keys which has been broken by defining multiple link items with the same destination path. The new "hosts" option structure allows to define any amount of hosts with their associated path.
arcticicestudio
deleted the
bugfix/ghi-#18-only-last-duplicate-link-item-processed-when-using-host-specific-option
branch
arcticicestudio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
hostsoption of thelinkcore plugin issued in #18.Changes
The internal type has been changed from a Python builtin
listto adictto allow to define multiple hosts with an associated path.Bug description
The bug occured because the builtin Python dictionary only allows unique keys which has been broken by defining multiple link items with the same destination path. The new
hostsoption structure allows to define any amount of hosts with their associated path.New format example configuration
[ { "clean": ["~"] }, { "link": { "~/.makepkg.conf": null, "~/.pacman.conf": { "hosts": { "igloo": "pacman.conf.igloo", "archbook": "pacman.conf.archbook" } } } } ]