Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated CanProcessMessage<> with message context #297

Closed
Tracked by #311
stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #308
Closed
Tracked by #311

Remove deprecated CanProcessMessage<> with message context #297

stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #308
Assignees
@pcarmo
Labels
area:message-processing All issues related to how we process the messages breaking-change All issues related to code breaking changes. good first issue Good for newcomers
Projects
Roadmap
Milestone
v2.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Previously, we were only filtering messages based on message context but since we added message body filtering and custom message deserialization, we added a dedicated CanProcessMessageBasedOnContext<>.

Describe the solution you'd like
Remove the deprecated CanProcessMessage method from the MessageHandler in the Arcus.Messaging.Abstractions project.
@stijnmoreels stijnmoreels added good first issue Good for newcomers area:message-processing All issues related to how we process the messages breaking-change All issues related to code breaking changes. labels Jun 13, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Jun 13, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Jun 13, 2022
This was referenced Jun 21, 2022
Closed
Merged
@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
stijnmoreels added a commit that referenced this issue Dec 25, 2023
@pcarmo @stijnmoreels
chore: removing deprecated code (#308)
23c58b6 
* chore: removed the deprecated CanProcessMessage method from the MessageHandler in the Arcus.Messaging.Abstractions project - issue #297

* chore: removed the AsServiceBusMessage to create a ServiceBusMessage instance in the Arcus.Messaging.ServiceBus.Core project - issue  #296

* chore: removed ObjectExtensions.cs since the extension class got empty after removing AsServiceBusMessage deprecated method - related to issue #296

* chore: removed deprecated MessageCorrelationInfoEnricher in pump namespace - issue #300

* Removed unexistant namespace Arcus.Messaging.Pumps.Abstractions.Telemetry due to deprecated MessageCorrelationInfoEnricher deletion - issue #300

* Fixed unit test related with the deletion of the deprecated CanProcessMessage method - issue #297

* Fixed unit tests related with the removal of the object extension AsServiceBusMessage - issue #296

---------

Co-authored-by: Stijn Moreels <9039753+stijnmoreels@users.noreply.github.com>
Roadmap automation moved this from To do to Done Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcarmo pcarmo

Labels
area:message-processing All issues related to how we process the messages breaking-change All issues related to code breaking changes. good first issue Good for newcomers
Projects
Roadmap
  
Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

chore: removing deprecated code
2 participants
@stijnmoreels @pcarmo