Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update towards net6.0 #260

Merged
merged 16 commits into from
Mar 31, 2022
Merged

chore: update towards net6.0 #260

merged 16 commits into from
Mar 31, 2022

Conversation

stijnmoreels
Copy link
Member

Add .NET 6 support, whilst still supporting .NET Core.

Relates to arcus-azure/arcus#106

@stijnmoreels stijnmoreels added this to the v1.2.0 milestone Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022 •
edited

✅ Deploy Preview for arcus-messaging canceled.

Name Link
🔨 Latest commit 0bf3093
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/6243e8a275f14700087c526d

@stijnmoreels stijnmoreels marked this pull request as draft March 22, 2022 07:41
@stijnmoreels stijnmoreels changed the title chore: update towards net6.0 chore: update towards net6.0 (🚧) Mar 22, 2022
@stijnmoreels
Copy link
Member Author

stijnmoreels commented Mar 23, 2022 •
edited

@fgheysels , not sure what I'm doing wrong here: https://dev.azure.com/codit/Arcus/_build/results?buildId=60218&view=logs&j=af2770d6-9849-5611-d90b-14595ba0772b&t=d498e235-96e9-5261-421a-d6ea71f144f9
My Docker knowledge fails me here 😢 .
The .NET Core requirement keeps bugging.

@fgheysels
Copy link
Member

@fgheysels , not sure what I'm doing wrong here: https://dev.azure.com/codit/Arcus/_build/results?buildId=60218&view=logs&j=af2770d6-9849-5611-d90b-14595ba0772b&t=d498e235-96e9-5261-421a-d6ea71f144f9 My Docker knowledge fails me here 😢 . The .NET Core requirement keeps bugging.

Maybe you need to update the Functions SDK (Microsoft.NET.Sdk.Functions) from 3.0.11 to 4.1.0 ?

@stijnmoreels
Copy link
Member Author

@fgheysels , not sure what I'm doing wrong here: https://dev.azure.com/codit/Arcus/_build/results?buildId=60218&view=logs&j=af2770d6-9849-5611-d90b-14595ba0772b&t=d498e235-96e9-5261-421a-d6ea71f144f9 My Docker knowledge fails me here 😢 . The .NET Core requirement keeps bugging.

Maybe you need to update the Functions SDK (Microsoft.NET.Sdk.Functions) from 3.0.11 to 4.1.0 ?

🙌 Yes! That was it. Thanks for this! Was not paying attention to that.

@stijnmoreels stijnmoreels changed the title chore: update towards net6.0 (🚧) chore: update towards net6.0 Mar 24, 2022
@stijnmoreels stijnmoreels marked this pull request as ready for review March 24, 2022 07:23
@fgheysels fgheysels removed their assignment Mar 24, 2022
@fgheysels fgheysels assigned stijnmoreels and unassigned fgheysels Mar 29, 2022
fgheysels
fgheysels approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgheysels fgheysels merged commit 3ff6e00 into arcus-azure:master Mar 31, 2022
@stijnmoreels stijnmoreels deleted the chore/update-towards-net6.0 branch March 31, 2022 09:04
@stijnmoreels stijnmoreels linked an issue May 4, 2022 that may be closed by this pull request
Add support for open message handler interface extraction in Azure Functions .NET 6 #249
Closed
@stijnmoreels stijnmoreels mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgheysels fgheysels fgheysels approved these changes

Assignees

@fgheysels fgheysels

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Add support for open message handler interface extraction in Azure Functions .NET 6
2 participants
@stijnmoreels @fgheysels