Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated SQL dependency tracking overloads #391

Closed
stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #555
Closed

Remove deprecated SQL dependency tracking overloads #391

stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #555
Assignees
@stijnmoreels
Labels
breaking-change All issues that require to do a breaking chnage dependencies All issues related to dependencies good first issue Good for newcomers
Milestone
v3.0.0

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Jun 13, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Previously, we used the DependencyMeasurement and a table/operation name combination to track a SQL dependency.

Describe the solution you'd like
Remove the deprecated logger extensions overload in the Arcus.Observability.Telemetry.Sql and Arcus.Observability.Telemetry.Core projects that still uses the DependencyMeasurement type and are missing the pseudo SQL command parameter.
@stijnmoreels stijnmoreels added good first issue Good for newcomers dependencies All issues related to dependencies labels Jun 13, 2022
@stijnmoreels stijnmoreels added this to the v3.0.0 milestone Jun 13, 2022
@stijnmoreels stijnmoreels added the breaking-change All issues that require to do a breaking chnage label Jun 13, 2022
@stijnmoreels stijnmoreels modified the milestones: v3.0.0, v4.0.0 Sep 15, 2023
@stijnmoreels stijnmoreels self-assigned this Nov 14, 2023
@stijnmoreels stijnmoreels mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
breaking-change All issues that require to do a breaking chnage dependencies All issues related to dependencies good first issue Good for newcomers
Projects
Roadmap
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove obsolete sql telemetry stijnmoreels/arcus.observability
1 participant
@stijnmoreels