feat: Ambiguous method definition on LogMetric

[vincenttermaat]

Ambiguous method definition on LogMetric
Closes #280

• Update Arcus.Testing.Logging 0.3.0 > 0.4.0
• Rename LogMetric to LogCustomMetric
• Mark LogMetric as obsolete
• Rename LogEvent to LogCustomEvent
• Mark LogEvent as obsolete

[netlify]

✅ Deploy Preview for arcus-observability ready!

Name	Link
🔨 Latest commit	70566aa
🔍 Latest deploy log	https://app.netlify.com/sites/arcus-observability/deploys/62c81b47eaeceb00088ad332
😎 Deploy Preview	https://deploy-preview-424--arcus-observability.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[stijnmoreels]

We should also reflect these changes in the feature documentation so people are guided towards these new extensions.
Thx again for your work! 💯 Really help us with all these many tasks across repo's (that we often forget 😄 ).

[vincenttermaat]

We should also reflect these changes in the feature documentation so people are guided towards these new extensions. Thx again for your work! 💯 Really help us with all these many tasks across repo's (that we often forget 😄 ).

starting on this

[vincenttermaat]

We should also reflect these changes in the feature documentation so people are guided towards these new extensions. Thx again for your work! 💯 Really help us with all these many tasks across repo's (that we often forget 😄 ).

starting on this

3dde0c3

[stijnmoreels]

This is fine for me. Thx for the update! Looks great. 😄

[stijnmoreels]

Woops, we're having some conflicts in the feature documentation, @vtermaat .
Probably bc we have changed the order of the files/folders. Normally, Git should be smart enough, so if you would update your master locally, and merge it back into this branch, it should resolve (easily) (hopefully, 😅 ).

[fgheysels]

What about the rename of LogEvent to LogCustomEvent. Should we keep that or revert that @stijnmoreels ?

[stijnmoreels]

What about the rename of LogEvent to LogCustomEvent. Should we keep that or revert that @stijnmoreels ?

It was added here as part of the LogMetric > LogCustomMetric change to streamline our extensions. It's fine for me as it supports consistency and will maybe be easier to find as it's also called 'custom events' in Application Insights, right?

[fgheysels]

What about the rename of LogEvent to LogCustomEvent. Should we keep that or revert that @stijnmoreels ?

It was added here as part of the LogMetric > LogCustomMetric change to streamline our extensions. It's fine for me as it supports consistency and will maybe be easier to find as it's also called 'custom events' in Application Insights, right?

I actually thought that it was just called an 'event' in AppInsights. However, I looked around and indeed, they're saved to a table called customEvents, and in the documentation they also (sometimes) refer to it as custom events.
I had some doubts about this (see also what I mentionned in the issue), but OK.

I can agree with this. (Sorry for being a bit 'picky' sometimes when we're discussing things about naming stuff).

[stijnmoreels]

I can agree with this. (Sorry for being a bit 'picky' sometimes when we're discussing things about naming stuff).

Hihi, 😄 , no need to apologize, I'm glad I'm not the only one to be picky on this. 😉 Glad that we find each other in this.