Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(❗) fix: null-check on scalar value #459

Merged

Conversation

stijnmoreels
Copy link
Member

Reason why the Azure Functions didn't always tracked the request, was that the operation parent ID was null in the initial call and this null wasn't checked when parsing the Serilog values to typed variants.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit 366fcf3
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/6308716703f1a000097ff51a

@stijnmoreels stijnmoreels changed the title fix: null-check on scalar value (❗) fix: null-check on scalar value Aug 26, 2022
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@stijnmoreels stijnmoreels merged commit 8e2da8b into arcus-azure:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants