Feature - track Azure Key Vault dependency #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new preview package for You can pull it locally via the CLI: PM> Install-Package Arcus.Security.All -Version 20201112.0.0-PR-207 -Source https://www.myget.org/F/arcus/api/v3/index.json |
tomkerkhove
reviewed
Nov 12, 2020
src/Arcus.Security.Providers.AzureKeyVault/Configuration/KeyVaultOptions.cs
Show resolved
Hide resolved
src/Arcus.Security.Providers.AzureKeyVault/KeyVaultSecretProvider.cs
Outdated
Show resolved
Hide resolved
We could do that, I'll have to set up a Serilog logger so we can use our sink. |
|
tomkerkhove
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opt-in to track the Azure Key Vault dependency, while maintaining backwards compatibility towards the preview v1.3.0 (which didn't have mutate secret names).
Closes #182
Relates to #177