forked from wg/epgsql
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4c8f96c
commit d80619f
Showing
2 changed files
with
33 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
*.boot | ||
*.script | ||
ebin/*.app | ||
.eunit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d80619f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have some benchmarks or test case that show results of the optimisation?
I did something similar in https://github.com/mabrek/epgsql/blob/async/src/pgsql_wire.erl#L39 , but didn't compare decoding speed because it wasn't a bottleneck in my case.
d80619f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was something like 32% of the execution time was in the
decode_string
function.My code decreased it to 28%. Not so much.
I did not tested the code with
binary:split
, but it can be even more slow. :/