Maintenance, moving to cjs, and node20 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Per convention, renaming all `.js` to `.cjs` - Updating to NodeJS 18
Adds no value.
node18 isn't a choice, going to 20.
Swapping ncc out for esbuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes a small handful of maintenance tasks that were impeding further development.
.cjsextensions. There are a bunch of tools which make these assumptions, and I'm tired of fighting with config files to get around this silly limitation. As a result, I have renamed the files.cjs.@vercel/ncchas good support for CommonJS modules. I'm not sure how true this is, but after 90 minute of fighting with it I decided to jettisonnccforesbuild.