Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'NoOpMediator' does not implement interface member #308

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix 'NoOpMediator' does not implement interface member #308

merged 1 commit into from
Jan 12, 2022

Conversation

askazakov
Copy link
Contributor

I have two compilation errors:

  NoOpMediator.cs(5, 29): [CS0535] 'NoOpMediator' does not implement interface member 'ISender.CreateStream<TResponse>(IStreamRequest<TResponse>, CancellationToken)'
  NoOpMediator.cs(5, 29): [CS0535] 'NoOpMediator' does not implement interface member 'ISender.CreateStream(object, CancellationToken)'

I use workaround from dotnet/runtime#1128

@askazakov askazakov mentioned this pull request Jan 12, 2022
Open
@ardalis
Copy link
Owner

ardalis commented Jan 12, 2022

Starting to think MediatR should just ship a NoOpMediator...

@ardalis ardalis merged commit 5b167e3 into ardalis:main Jan 12, 2022
@DavidBruchmann
Copy link

DavidBruchmann commented Mar 19, 2022 •
edited

Perhaps someone can explain the sense of NoOpMediator?
https://stackoverflow.com/questions/71008347/what-is-noopmediator-in-clean-architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@askazakov @ardalis @DavidBruchmann