Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Contributor List SQL #685

Merged
merged 1 commit into from Feb 23, 2024
Merged

Fix Contributor List SQL #685

merged 1 commit into from Feb 23, 2024

Conversation

mickymcq
Copy link
Contributor

Fixes #682

  • Alias the phone number column name so that it works with the ContributorDTO
  • Convert NULL to empty string to work with the ContributorDTO PhoneNumber property which is a string and not a string?

@mickymcq mickymcq changed the title Fix Contributor List SQL (#682) Fix Contributor List SQL Feb 19, 2024
@mickymcq
Copy link
Contributor Author

@ardalis, this is my first PR to your CleanArchitecture repo. Is there anything you'd like me to do differently for this one or follow-up PRs?

@ardalis ardalis merged commit 059bf9c into ardalis:main Feb 23, 2024
@ardalis
Copy link
Owner

ardalis commented Feb 23, 2024

Nope you're good. I've just been super busy this week. Thanks!

@mickymcq mickymcq deleted the contributor-list branch February 23, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test case ReturnsTwoContributors() fails
2 participants
@mickymcq @ardalis