New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributor PhoneNumber nullability for consistency #686

Merged

ardalis merged 3 commits into main from kylemcmaster/fix-contributor-dto-nullability

Feb 29, 2024

Collaborator

KyleMcMaster commented Feb 29, 2024 •

edited

Since the domain model for Contributor has a nullable PhoneNumber, ContributorDTO should also have that nullability rather than conflicting between null and "".
Minor code cleanup as well

Related to #682

KyleMcMaster added 3 commits

February 28, 2024 18:01


          Adjust PhoneNumber nullability throughout layers


          remove wwwroot from csproj

f415587


          add LINQ expression back in for in memory provider

71ccb8c

ardalis approved these changes

View reviewed changes

ardalis merged commit dfc4b02 into main

3 checks passed

ardalis deleted the kylemcmaster/fix-contributor-dto-nullability branch

February 29, 2024 02:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment