Migrate Autofac DI -> Native DI in Asp.Net Core #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sauravbhattacharya001
commented
Mar 2, 2024
sauravbhattacharya001
commented
- Remove the Autofac ContainerBuilder configuration
- Set up DI in the Program.cs top-level file
- Clean up Autofac in packages, documentation, and other helper classes.
Co-authored-by: cameronslatton@gmail.com Co-authored-by: marcotello5@outlook.com Co-authored-by: spitale@hotmail.it
|
Fixes #694 |
KyleMcMaster
reviewed
Mar 3, 2024
Co-authored-by: Kyle McMaster <KyleMcMaster@users.noreply.github.com>
sdepouw
approved these changes
Mar 3, 2024
KamRon-67
reviewed
Mar 3, 2024
| } | ||
| } | ||
|
|
||
| builder.Services.AddScoped(typeof(IRepository<>), typeof(EfRepository<>)); |
There was a problem hiding this comment.
We should clean this up.
I wrote a blog post on this topic.
In Program.cs builder is in scope wherever you use it.
KyleMcMaster
reviewed
Mar 4, 2024
Comment on lines
+62
to
+86
| var mediatrOpenTypes = new[] | ||
| { | ||
| containerBuilder.RegisterModule(new DefaultCoreModule()); | ||
| containerBuilder.RegisterModule(new AutofacInfrastructureModule(builder.Environment.IsDevelopment())); | ||
| }); | ||
| typeof(IRequestHandler<,>), | ||
| typeof(IRequestExceptionHandler<,,>), | ||
| typeof(IRequestExceptionAction<,>), | ||
| typeof(INotificationHandler<>), | ||
| }; | ||
|
|
||
| foreach (var assembly in assemblies) | ||
| { | ||
| foreach (var openInterfaceType in mediatrOpenTypes) | ||
| { | ||
| if (assembly != null) | ||
| { | ||
| assembly.GetTypes() | ||
| .Where(t => t.IsClass && !t.IsAbstract && t.GetInterfaces().Any(i => i.IsGenericType && i.GetGenericTypeDefinition() == openInterfaceType)) | ||
| .ToList() | ||
| .ForEach(implementationType => | ||
| { | ||
| var serviceType = implementationType.GetInterfaces().First(i => i.IsGenericType && i.GetGenericTypeDefinition() == openInterfaceType); | ||
| builder.Services.AddScoped(serviceType, implementationType); | ||
| }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this loop be removed in favor of using MediatR's own DI registration method?
builder.Services.AddMediatR(cfg => cfg.RegisterServicesFromAssemblies(assemblies));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.