Refactor OutOfRange to generic #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 1, 2021 11:12
|
Thanks! I'll check this out when I have a chance. Does it break existing calls to the type specific methods? I assume yes but one can hope... |
|
All existing UnitTests are green, no adaption were necessary. |
ardalis
approved these changes
Oct 7, 2021
|
Thanks! |
|
It was a pleasure for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ardalis,
As discussed yesterday i refactored the OutOfRange implementations (~ 200 LOC less)
add tests for uint
and as an example for IComparable usage, a test with tuples
hth
eg