Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new CI and Release workflows. #350

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

fiseni
Copy link
Collaborator

@fiseni fiseni commented Jul 23, 2023

Closes #349. Please check the related issue for more details.
Removed the old workflows and created two new ones. I think the workflows now are stupid simple :)

  • ci.yml - Build and test, triggered on pr and push on main. Triggered only if there are changes in the library projects. All other changes for docs or sample apps won't trigger anything. It's tedious if CI is triggered on each doc change.
  • release.yml - Triggered on release publish. We're anyway always creating releases from Github, so let's use that event. This will publish all three packages (but that's what we're always doing). If in the future we need to publish them independently, we might use different tags for each package, but for now, that seems unnecessary.

The solution contains sample apps too, but I didn't want to build them as part of the workflows. So, instead of passing all the required projects as an argument to dotnet build, I created a solution filter ci.slnf which contains only the necessary projects. I think this was a great trick, and makes the yml files way cleaner.

@fiseni fiseni requested a review from ardalis July 23, 2023 13:55
@ardalis ardalis merged commit aeb9467 into main Jul 24, 2023
@ardalis
Copy link
Owner

ardalis commented Jul 24, 2023

Sounds great; let's see them in action!

@ardalis
Copy link
Owner

ardalis commented Jul 24, 2023

Also, nice use of a solution filter; I probably would have created a separate ci.sln file to do the same thing, but your approach is cleaner I think.

@fiseni fiseni deleted the fiseni/workflow-updates branch July 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pipelines.
2 participants