Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy PR to test the triggers. #352

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Dummy PR to test the triggers. #352

merged 1 commit into from
Jul 24, 2023

Conversation

fiseni
Copy link
Collaborator

@fiseni fiseni commented Jul 24, 2023

No description provided.

@fiseni
Copy link
Collaborator Author

fiseni commented Jul 24, 2023

@ardalis The PR triggered the correct workflow.

On merge, this will run again. If you protect the main branch, so we're sure nobody can push directly to the main, then perhaps we don't need the push trigger. It doesn't hurt, but it's just wasting resources.

@fiseni
Copy link
Collaborator Author

fiseni commented Jul 24, 2023

Actually, we should leave it as it is. We should run it on merge too, so the builds are visible on the commit history. That affects the badges I assume, so better to have it.

@ardalis ardalis merged commit 6405783 into main Jul 24, 2023
1 check passed
@fiseni fiseni deleted the fiseni/dummy branch July 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fiseni @ardalis