Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages to obsolete specs for clarity #373

Merged

Conversation

Rowe2ryWA
Copy link
Contributor

@Rowe2ryWA Rowe2ryWA commented Sep 14, 2023

Super simple contribution but hopefully a helpful one.

I noticed the obsolete warnings when working in our organization's server repo and it took 15 minutes of research and git blame to find the commit where these were marked obsolete, study the code and determine what I should have been doing instead.

I figured I'd contribute to the project to save the next guy some time. Ardalis is a major backbone of our project so I hope this contribution helps. 馃檪

@fiseni
Copy link
Collaborator

fiseni commented Sep 14, 2023

Hi @Rowe2ryWA,

Thank you for taking the time to contribute here.
I have a suggestion. Would it be possible to change the message as follows? Mentioning ListAsync will just confuse the users.

"Use FirstOrDefaultAsync<T> or SingleOrDefaultAsync<T> instead. The SingleOrDefaultAsync<T> can be applied only to SingleResultSpecification<T> specifications."

@Rowe2ryWA
Copy link
Contributor Author

Hi @Rowe2ryWA,

Thank you for taking the time to contribute here. I have a suggestion. Would it be possible to change the message as follows? Mentioning ListAsync will just confuse the users.

"Use FirstOrDefaultAsync<T> or SingleOrDefaultAsync<T> instead. The SingleOrDefaultAsync<T> can be applied only to SingleResultSpecification<T> specifications."

Yes, I will make the edits and update the branch.

@fiseni
Copy link
Collaborator

fiseni commented Sep 14, 2023

Thanks!

@fiseni fiseni merged commit fab04ee into ardalis:main Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants