New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config mutex locking error #49

Closed

ghost opened this issue Jul 12, 2017 · 1 comment · Fixed by #50

ghost commented Jul 12, 2017

Why do you lock mutex for reading in Set... methods?

func (c *Config) SetString(key string, value string) {
	c.mu.RLock()
	{
		c.m[key] = value
	}
	c.mu.RUnlock()
}

is this copypast?

Contributor

wyattjoh commented Jul 12, 2017

That definitely looks like a bug! Thanks for that catch @finalist736

wyattjoh added a commit that referenced this issue


          Resolves #49

1ddcf50

wyattjoh mentioned this issue

Config Lock #50

Merged

ardan-bkennedy closed this as completed in #50

ardan-bkennedy pushed a commit that referenced this issue


          Resolves #49 (#50)

42c5048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment