Question: Respond before commit transaction

[suppakorn-dev]

Following the handler code, you respond before committing the transaction in the middleware. What would happen if the tx.Commit() call returns an error?

[ardan-bkennedy]

Hmmmm. Right the handler will send the OK response, and then the middleware will unwind. There is a chance the Commit fails. In that case, the error middleware would log the error, the call to send a second response would happen, before closing the connection. Until we actually try it, I'm not 100% sure. I am going to try this now.

[ardan-bkennedy]

@suppakorn-dev you opened a can of worms. hahahahaha

I have made changes to support the middleware rolling back and responding properly. It required changes to the web package and protocol layer code. The code is better for it.

Thanks!

[PH9]

Fixed with #387 🎉