fix(federation): do not import @link from spec

ardatan · Feb 14, 2023 · 696f9c7 · 696f9c7
1 parent db11a7d
commit 696f9c7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/.changeset/lemon-comics-brake.md b/.changeset/lemon-comics-brake.md
@@ -0,0 +1,5 @@
+---
+'@graphql-mesh/transform-federation': patch
+---
+
+Do not import @link from the spec
diff --git a/packages/transforms/federation/src/index.ts b/packages/transforms/federation/src/index.ts
@@ -194,16 +194,19 @@ export default class FederationTransform implements MeshTransform {
     schemaWithUnionType.extensions = schemaWithUnionType.extensions || {};
     const directivesObj: any = ((schemaWithUnionType.extensions as any).directives =
       schemaWithUnionType.extensions.directives || {});
-    directivesObj.link = {
-      url: 'https://specs.apollo.dev/federation/' + (this.config.version || 'v2.0'),
-      import: federationDirectives.filter(name => name !== 'link').map(dirName => `@${dirName}`),
-    };
 
     const existingDirectives = schemaWithUnionType.getDirectives();
     const filteredDirectives = existingDirectives.filter(directive =>
       federationDirectives.includes(directive.name),
     );
 
+    directivesObj.link = {
+      url: 'https://specs.apollo.dev/federation/' + (this.config.version || 'v2.0'),
+      import: filteredDirectives
+        .filter(({ name }) => name !== 'link')
+        .map(dirName => `@${dirName.name}`),
+    };
+
     if (existingDirectives.length === filteredDirectives.length) {
       return schemaWithUnionType;
     }

diff --git a/packages/transforms/federation/test/federation.spec.ts b/packages/transforms/federation/test/federation.spec.ts
@@ -38,7 +38,7 @@ describe('transform-federation', () => {
       schema,
     });
     expect(printSchemaWithDirectives(transformedSchema)).toMatchInlineSnapshot(`
-      "schema @link(url: "https://specs.apollo.dev/federation/v2.0", import: ["@extends", "@external", "@inaccessible", "@key", "@override", "@provides", "@requires", "@shareable", "@tag"]) {
+      "schema @link(url: "https://specs.apollo.dev/federation/v2.0", import: []) {
         query: Query
       }