Feedback for “GraphQL Response Caching”

[dventimihasura]

The docs say for the if config option:

Specify whether the cache should be used based on the context.

What is the context? How do I reference it? What attributes does it contain? How, for instance, would I build an if config option that references the GraphQL operationName from the context?

[ardatan]

You can see how dynamic variables work here;
https://the-guild.dev/graphql/mesh/docs/guides/dynamic-vars#context-variable

[Urigo]

@dventimihasura do you think we can maybe the docs better on this?
would you be open to create a PR with changes you think make it clearer for others?

[dventimihasura]

@Urigo we can all do better on our docs. I'd be happy to try to contribute some improvements. ✔️

[dventimihasura]

@ardatan @Urigo meanwhile I guess the difficulty I have is that in the docs section Dynamic Variables, it says that usage is quoted with curly braces {} but in the docs for the Response Caching plugin the examples have a mixture of doublie quotes "", curly braces {} sometimes combined sometimes not. If I use the example given, verbatim:

if: "context.headers.userId != null"

there's an error.

$ /home/hasura/node_modules/.bin/mesh dev --dir /home/hasura/Downloads/
🐛 🕸️  Mesh - GetMesh Getting subschemas from source handlers
🐛 🕸️  Mesh - faker Generating the schema
💡 🕸️  Mesh - Server Starting GraphQL Mesh...
🐛 🕸️  Mesh - faker The schema has been generated successfully
🐛 🕸️  Mesh - faker Analyzing transforms
🐛 🕸️  Mesh - GetMesh Schemas have been generated by the source handlers
🐛 🕸️  Mesh - GetMesh Merging schemas using the defined merging strategy.
🐛 🕸️  Mesh - bareMerger Attaching a dummy sourceMap to the final schema
Transformed schema is not set yet. Returning a dummy one.
💡 🕸️  Mesh Generating index file in TypeScript
💡 🕸️  Mesh - Server Serving GraphQL Mesh: http://0.0.0.0:4000
💡 🕸️  Mesh Writing index.ts for ESM to the disk.
💡 🕸️  Mesh Writing index.ts for CJS to the disk.
🐛 🕸️  Mesh Rendering GraphiQL
ReferenceError: context is not defined
    at eval (eval at enabled (/home/hasura/node_modules/@graphql-mesh/plugin-response-cache/cjs/index.js:23:16), <anonymous>:3:1)
    at enabled (/home/hasura/node_modules/@graphql-mesh/plugin-response-cache/cjs/index.js:23:47)
    at onRequest (/home/hasura/node_modules/@graphql-yoga/plugin-response-cache/cjs/index.js:62:17)
    at handleRequest (/home/hasura/node_modules/@whatwg-node/server/cjs/createServerAdapter.js:55:19)
    at async handleRequest (/home/hasura/node_modules/@whatwg-node/router/index.js:99:40)
    at async handleRequest (/home/hasura/node_modules/@whatwg-node/server/cjs/createServerAdapter.js:73:24)
    at async requestListener (/home/hasura/node_modules/@whatwg-node/server/cjs/createServerAdapter.js:100:26)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I guess I'll keep trying different combinations until I find something that works.

[dventimihasura]

BTW I like the spider webs. They're very scary.

[mnlbox]

@dventimihasura, did you find a working syntax for this if option in the ResponseCache plugin?
I guess I have the same issue here:
#5842