Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL - Subscription Endpoint not being Interpolated #5403

Closed
4 tasks
steve-gray opened this issue May 7, 2023 · 1 comment
Closed
4 tasks

GraphQL - Subscription Endpoint not being Interpolated #5403

steve-gray opened this issue May 7, 2023 · 1 comment

Comments

@steve-gray
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

The endpoint in the .meshrc.yaml file does not get environment variables interpolated, causing Websocket / Websocket legacy requests to fail where the URL is specified in this way. The URL is interpolated correctly when doing schema fetching and for non-subscription queries, but does not get interpolated before being passed to the websocket drivers (both legacy WS and WS), causing requests to fail.

To Reproduce Steps to reproduce the behavior:

  • Use an environment variable to specify the GraphQL handler endpoint
  • Try to subscribe to data.

The issue applies both when using a single endpoint and when using a dedicated subscriptionEndpoint.

Expected behavior

Should be interpolated correctly with environment variables and other tokens, and allow this.

Additional context

Was the root problem that led to me reporting #5402

@ardatan
Copy link
Owner

ardatan commented Jun 12, 2023

Fixed in e4f94eb

@ardatan ardatan closed this as completed Jun 12, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants