Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate load options from the config to the gRPC handler #5278

Merged
merged 1 commit into from Apr 3, 2023

Conversation

igor-ag5
Copy link
Contributor

@igor-ag5 igor-ag5 commented Apr 2, 2023

Description

Propagate load options from the mesh config to the gRPC handler

Fixes #5277

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually

Test Environment:

  • OS: macOS Ventura 13.2.1
  • Package versions
"@graphql-mesh/cli": "^0.82.23",
"@graphql-mesh/graphql": "^0.34.6",
  • NodeJS: v18.14.1

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2023

⚠️ No Changeset found

Latest commit: 2e5a1ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan
Copy link
Owner

ardatan commented Apr 3, 2023

Thanks @igor-ag5 !

@ardatan ardatan merged commit 6302490 into ardatan:master Apr 3, 2023
6 of 12 checks passed
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
@alexfiu4
Copy link

alexfiu4 commented Apr 4, 2024

Hi,
@ardatan, @igor-ag5 the issue is still reproducable with latest library version.
I'm working with "@graphql-mesh/grpc": "^0.98.5"

This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC handler: load defaults option not working
3 participants