Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow deep merging objects in allOf operations #5643

Conversation

cweckesser
Copy link
Contributor

@cweckesser cweckesser commented Jul 6, 2023

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes #5641

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Code Sandbox

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • A unit test was added that verifies that when processing a model containing two object-type sub-properties with overriding attributes, the resulting model properly merges the sets of properties from the two objects

Test Environment:

  • OS: macOS
  • "@omnigraph/openapi": "^0.94.6",
  • NodeJS: 16

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

馃 Changeset detected

Latest commit: edc5a63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@omnigraph/json-schema Patch
@omnigraph/openapi Patch
@graphql-mesh/json-schema Patch
@omnigraph/raml Patch
@graphql-mesh/openapi Patch
auth0-example Patch
cloudflare-workers Patch
example-gcp Patch
hasura-openbrewery-geodb Patch
hello-world-esm Patch
json-schema-hello-world Patch
covid-mesh Patch
json-schema-example Patch
json-schema-fhir Patch
json-schema-file-upload Patch
json-schema-subscriptions Patch
reddit-example Patch
@graphql-mesh/raml Patch
nextjs-apollo-example Patch
nextjs-sdk-example Patch
javascript-wiki Patch
typescript-location-weather-example Patch
openapi-meilisearch Patch
openapi-orbit Patch
openapi-stackexchange Patch
openapi-stripe Patch
openapi-subscriptions Patch
openapi-youtrack Patch
programmatic-batching-example Patch
gateway-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cweckesser cweckesser marked this pull request as ready for review August 2, 2023 13:01
@ardatan
Copy link
Owner

ardatan commented Aug 10, 2023

Thank you @cweckesser ! This is an amazing work!

@ardatan ardatan merged commit 94afd25 into ardatan:master Aug 10, 2023
12 checks passed
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OmniGraph OpenAPI] Objects listed in allOf operator do not get deep merged
2 participants