Merge pull request #321 from nwfortner/master

bug fix. added type check for addMockFunctionsToSchema first arg

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change log
 
 ### vNEXT
+* Add argument validation in `addMockFunctionsToSchema` for 'schema' property in parameter object [PR #321](https://github.com/apollographql/graphql-tools/pull/321) 
 
 ### v0.11.0
 * Remove dependency on `graphql-subscription` and use an interface for PubSub [PR #295](https://github.com/apollographql/graphql-tools/pull/295)

src/mock.ts

@@ -43,9 +43,11 @@ function addMockFunctionsToSchema({ schema, mocks = {}, preserveResolvers = fals
   }
 
   if (!schema) {
-    // XXX should we check that schema is an instance of GraphQLSchema?
     throw new Error('Must provide schema to mock');
   }
+  if (!(schema instanceof GraphQLSchema)) {
+    throw new Error('Value at "schema" must be of type GraphQLSchema');
+  }
   if (!isObject(mocks)) {
     throw new Error('mocks must be of type Object');
   }

src/test/testMocking.ts

@@ -90,6 +90,11 @@ describe('Mock', () => {
                   .to.throw('Must provide schema to mock');
   });
 
+  it('throws an error if the property "schema" on the first argument is not of type GraphQLSchema', () => {
+    expect(() => (<any> addMockFunctionsToSchema)({ schema: {}}))
+                  .to.throw('Value at "schema" must be of type GraphQLSchema');
+  });
+
   it('throws an error if second argument is not a Map', () => {
     const jsSchema = buildSchemaFromTypeDefinitions(shorthand);
     expect(() => (<any> addMockFunctionsToSchema)({ schema: jsSchema, mocks: ['a'] }))