fix(url-loader): do not pass credentials: same-origin by default

.changeset/ninety-taxis-kneel.md

@@ -0,0 +1,7 @@
+---
+'@graphql-tools/url-loader': minor
+---
+
+Do not pass credentials: same-origin by default because it is already default per spec
+
+This prevents an error like (The 'credentials' field on 'RequestInitializerDict' is not implemented.) on the environments that don't support `credentials` flag like CF Workers.

packages/loaders/url/src/index.ts

@@ -135,10 +135,9 @@ export interface LoadFromUrlOptions extends BaseLoaderOptions, Partial<Introspec
   timeout?: number;
   /**
    * Request Credentials (default: 'same-origin')
-   * You can pass `disable` if you don't want this to be set in `Request`
    * @see https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials
    */
-  credentials?: RequestCredentials | 'disable';
+  credentials?: RequestCredentials;
   /**
    * Connection Parameters for WebSockets connection
    */
@@ -361,8 +360,6 @@ export class UrlLoader implements Loader<LoadFromUrlOptions> {
         }, options.timeout);
       }
 
-      const credentials = options?.credentials !== 'disable' ? options?.credentials || 'same-origin' : null;
-
       return new ValueOrPromise(() => {
         switch (method) {
           case 'GET':
@@ -374,7 +371,7 @@ export class UrlLoader implements Loader<LoadFromUrlOptions> {
               finalUrl,
               {
                 method: 'GET',
-                ...(credentials != null ? { credentials } : {}),
+                ...(options?.credentials != null ? { credentials: options.credentials } : {}),
                 headers,
                 signal: controller?.signal,
               },
@@ -390,7 +387,7 @@ export class UrlLoader implements Loader<LoadFromUrlOptions> {
                       endpoint,
                       {
                         method: 'POST',
-                        ...(credentials != null ? { credentials } : {}),
+                        ...(options?.credentials != null ? { credentials: options.credentials } : {}),
                         body,
                         headers: {
                           ...headers,
@@ -408,7 +405,7 @@ export class UrlLoader implements Loader<LoadFromUrlOptions> {
                 endpoint,
                 {
                   method: 'POST',
-                  ...(credentials != null ? { credentials } : {}),
+                  ...(options?.credentials != null ? { credentials: options.credentials } : {}),
                   body: JSON.stringify(requestBody),
                   headers: {
                     'content-type': 'application/json',