Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve resolverValidationOptions #2103

Closed
xenoterracide opened this issue Oct 8, 2020 · 5 comments
Closed

improve resolverValidationOptions #2103

xenoterracide opened this issue Oct 8, 2020 · 5 comments

Comments

@xenoterracide
Copy link

so I'm looking specifically at these 2 options

  • requireResolversForNonScalar - this doesn't actually seem to require, it seems to warn, making it inconsistent with requireResolversForResolveType
  • requireResolversForResolveType -seems to have 3 states.

I think both would be better taking strings that define the behavior (in ts) 'warn' | 'error' | 'ignore'
@yaacovCR
Copy link
Collaborator

yaacovCR commented Oct 8, 2020

What are the three states of requireResolversForResolveType? Seems to take boolean, with undefined treated the same as false?

@yaacovCR
Copy link
Collaborator

yaacovCR commented Oct 8, 2020

Also -- this is a great idea!

@xenoterracide
Copy link
Author

I would say the same 3, that way you could error if there are missing __resolveType's, currently though they are the same as far as I can see.

@yaacovCR yaacovCR added the waiting-for-release Fixed/resolved, and waiting for the next stable release label Oct 10, 2020
yaacovCR added a commit that referenced this issue Oct 10, 2020
@yaacovCR
fix(generate): harmonize validators
10db869 
see #2103
@yaacovCR
Copy link
Collaborator

this hopefully will be fixed in v7

yaacovCR added a commit that referenced this issue Oct 23, 2020
@yaacovCR
fix(generate): harmonize validators
2c18604 
see #2103
@yaacovCR
Copy link
Collaborator

Released in v7

@yaacovCR yaacovCR removed the waiting-for-release Fixed/resolved, and waiting for the next stable release label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xenoterracide @yaacovCR