Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): standardize types #1364

Merged
merged 1 commit into from Apr 13, 2020
Merged

fix(types): standardize types #1364

merged 1 commit into from Apr 13, 2020

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Apr 12, 2020

= do not rely on external, non-exported graphql-js types
= provide backwards compatible ExecutionResult type that retains typecast from graphql-js <v15
= add extensions property from Result type to graphql-tools ExecutionResult type
= use ExecutionResult type instead of Result
= retain Result type for backwards-compatibility

= do not rely on external, non-exported graphql-js types
= provide backwards compatible ExecutionResult type that retains typecast from graphql-js <v15
= add extensions property from Result type to graphql-tools ExecutionResult type
= use ExecutionResult type instead of Result
= retain Result type for backwards-compatibility
@yaacovCR yaacovCR merged commit 9cdc5de into next Apr 13, 2020
@yaacovCR yaacovCR deleted the fix-types branch April 13, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant