Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid infinite loop #1505

Merged
merged 1 commit into from
May 19, 2020
Merged

avoid infinite loop #1505

merged 1 commit into from
May 19, 2020

Commits on May 19, 2020

  1. avoid infinite loop 

    fixSchemaAst fixes the schema ast by adding a getter for the property which lazily calls buildSchema(printSchemaWithDirectives(schema) to rebuild the schema.

printSchemaWithDirectives, however, now checks to see if schema.astNode is defined, and so will end up calling itself. This can be avoided by making sure that the astNode is not defined as a getter.

fixSchemaAst could alternatively be changed to return a new schema ratehr than modifying the original schema.
    @yaacovCR
    yaacovCR committed May 19, 2020
    Configuration menu
    Copy the full SHA
    60c5195 View commit details
    Browse the repository at this point in the history