Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $ from invalidPathRegex #2090

Merged
merged 2 commits into from Oct 27, 2020
Merged

Remove $ from invalidPathRegex #2090

merged 2 commits into from Oct 27, 2020

Conversation

dizel3d
Copy link
Contributor

@dizel3d dizel3d commented Oct 5, 2020

Problem: @graphql-codegen silently ignore paths with $.
Solution: remove $ from invalidPathRegex

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Problem: `@graphql-codegen` silently ignore paths with `$`.
Solution: remove `$` from `invalidPathRegex`
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2020

🦋 Changeset detected

Latest commit: 9843fa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan added the bugfix label Oct 5, 2020
@ardatan
Copy link
Owner

ardatan commented Oct 13, 2020

Thank you for the PR @dizel3d ! Could you add a changeset using yarn changeset?

@ardatan ardatan merged commit 8133a90 into ardatan:master Oct 27, 2020
@dizel3d dizel3d deleted the patch-1 branch October 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants