refactor(stitchingInfo): shift more calculation to build time #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- run collectFields on selectionSet hints at build time -- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a set
|
|
The latest changes of this PR are not available as alpha, since there are no linked |
ardatan
pushed a commit
that referenced
this pull request
Jul 25, 2021
-- run collectFields on selectionSet hints at build time -- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a Set
ardatan
pushed a commit
that referenced
this pull request
Jul 25, 2021
-- run collectFields on selectionSet hints at build time -- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a Set
ardatan
added a commit
that referenced
this pull request
Jul 26, 2021
No need for deepMerge use createDefaultExecutor Few improvements workflow_dispatch Not only master refactor(stitchingInfo): shift more calculation to build time (#3199) -- run collectFields on selectionSet hints at build time -- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a Set Use collectFields and ExecutionContext from graphql-js (#3200) refactor: use Set to avoid repetition (#3202) * use Set to deduplicate * further refactor refactor ExpandAbstractTypes as PrepareGatewayRequest will consolidate remaining pre-user supplied transforms into this transform to hopefully reduce repetition also adds memoization of schema metadata small refactors add visitorKeys argument small refactor import WrapConcreteFields into PrepareGatewayRequest this does not use the same visitors and does not visit beneath fields, so can just be inlined info should be optional in DelegationContext fix types Consolidate VisitSelectionSets rename var internalize PrepareGatewayDocument as transform as prepareGatewayDocument function move varName generator out of loop to prevent recurrent looping refactor AddArgumentsAsVariables rename AddArgumentsAsVariables to FinalizeGatewayRequest to consolidate post custom transforms arguments should be added to target final targetSchema not transformedSchema move FilterToSchema tests to delegate package starting refacotr of FilterToSchema add visitorArgs also -- unfortunately -- requires another visit pass to properly remove variables if an object or interface field does not have selections -- another approach could be to keep track of variable uses, and subtract at the end of the first pass integrate FilterToSchema into FinalizeGatewayRequest fold AddTypenameToAbstract into FinalizeGatewayRequest extract finalizeGatewayRequest function from the transform retire all delegation transforms fix build typo Experiment LRU Cache More promise LRU with Refactor Fix TS Build Try Print instead More cache Use JSON.stringify? Fix caching
ardatan
added a commit
that referenced
this pull request
Jul 26, 2021
* Experiment LRU Cache No need for deepMerge use createDefaultExecutor Few improvements workflow_dispatch Not only master refactor(stitchingInfo): shift more calculation to build time (#3199) -- run collectFields on selectionSet hints at build time -- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a Set Use collectFields and ExecutionContext from graphql-js (#3200) refactor: use Set to avoid repetition (#3202) * use Set to deduplicate * further refactor refactor ExpandAbstractTypes as PrepareGatewayRequest will consolidate remaining pre-user supplied transforms into this transform to hopefully reduce repetition also adds memoization of schema metadata small refactors add visitorKeys argument small refactor import WrapConcreteFields into PrepareGatewayRequest this does not use the same visitors and does not visit beneath fields, so can just be inlined info should be optional in DelegationContext fix types Consolidate VisitSelectionSets rename var internalize PrepareGatewayDocument as transform as prepareGatewayDocument function move varName generator out of loop to prevent recurrent looping refactor AddArgumentsAsVariables rename AddArgumentsAsVariables to FinalizeGatewayRequest to consolidate post custom transforms arguments should be added to target final targetSchema not transformedSchema move FilterToSchema tests to delegate package starting refacotr of FilterToSchema add visitorArgs also -- unfortunately -- requires another visit pass to properly remove variables if an object or interface field does not have selections -- another approach could be to keep track of variable uses, and subtract at the end of the first pass integrate FilterToSchema into FinalizeGatewayRequest fold AddTypenameToAbstract into FinalizeGatewayRequest extract finalizeGatewayRequest function from the transform retire all delegation transforms fix build typo Experiment LRU Cache More promise LRU with Refactor Fix TS Build Try Print instead More cache Use JSON.stringify? Fix caching * Fix mergeExtensions * Fix benchmark * More * Fix tests * Remove schemaTransforms * More fixes * Fix * More improvements * More improvements * More fixes? * Refactor w/o caching * Try sth * Reduce number of iterations * Reduce number of iterations * Small * Fix build * Cleanup * Add changeset * Fix build * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- run collectFields on selectionSet hints at build time
-- use a fieldNode cache at build time so that at run time we can collect unique fieldNodes simply by using a Set (rather than by printing nodes and using a Map)