Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for v16 #3481

Closed
wants to merge 1 commit into from
Closed

workaround for v16 #3481

wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Sep 2, 2021

in v15, could we never enter subfields because we don't visit any keys for nodes of kind Kind.FIELD which automatically means we only visit 'root fields', no matter how nested they are in fragment nodes.

In v16, visitorKeys is gone, and we have to enter child fields and explicitly exit by returning 'false'.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2021

⚠️ No Changeset found

Latest commit: 30494c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/78eYjbZ12zADgAGqCXPTeSmTFNmG
✅ Preview: https://graphql-tools-git-visitor-keys-workaround-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 2, 2021

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

@yaacovCR
Copy link
Collaborator Author

I believe this can be closed with the latest changes in v16

@yaacovCR yaacovCR closed this Sep 25, 2021
@ardatan ardatan deleted the visitor-keys-workaround branch November 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants