Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mock.js #42

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Update mock.js #42

merged 1 commit into from
Apr 27, 2016

Conversation

ssnau
Copy link
Contributor

@ssnau ssnau commented Apr 27, 2016

Math.random should be function call.

`Math.random` should be function call.
@apollo-cla
Copy link

@ssnau: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@helfer helfer merged commit 93dcca9 into ardatan:master Apr 27, 2016
@helfer
Copy link
Contributor

helfer commented Apr 27, 2016

Thanks!

I thought we have tests for this, but they still passed because of what I think is a bug in chai. I filed an issue there: chaijs/chai#691

@helfer
Copy link
Contributor

helfer commented Apr 27, 2016

Made sure the tests don't accept non-numbers any more: e7407d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants