New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce 'batch' flag, improve loadSchema and merge wrapped schemas properly #4535
Conversation
🦋 Changeset detectedLatest commit: 7db66bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The latest changes of this PR are available as alpha in npm (based on the declared
|
❌ Benchmark FailedPerformance regression detected: it seems like your Pull Request adds some extra latency to Schema Stitching
|
loadSchema
;No longer call
mergeSchemas
if a single schema is loaded.Previously all typeDefs and resolvers were extracted and the schema was rebuilt from scratch.
But this is not necessary if there is only one schema loaded with
loadSchema
mergeSchemas
was skippingdefaultFieldResolver
anddefaultMergedResolver
by default while extracting resolvers for each given schema to reduce the overhead. But this doesn't work properly if you mix wrapped schemas and local schemas. So newincludeDefaultMergedResolver
flag is introduced ingetResolversFromSchema
to put default "proxy" resolvers in the extracted resolver map formergeSchemas
.This fixes an issue with alias issue, so nested aliased fields weren't resolved properly because of the missing
defaultMergedResolver
in the final merged schema which should come from the wrapped schema.UrlLoader
:New 'batch' flag! Now you can configure your remote schema to batch parallel queries to the upstream.
Closes: #3267