Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TypeScript esm + esm and cjs import tests on CI #4539

Merged
merged 7 commits into from Jun 27, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jun 24, 2022

Closes #4532

@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ❌ Failed (Inspect) Jun 27, 2022 at 9:58AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2022

🦋 Changeset detected

Latest commit: 4c3bd99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@graphql-tools/batch-delegate Minor
@graphql-tools/batch-execute Minor
@graphql-tools/delegate Minor
@graphql-tools/graphql-tag-pluck Minor
graphql-tools Minor
@graphql-tools/import Minor
@graphql-tools/jest-transform Minor
@graphql-tools/links Minor
@graphql-tools/load Minor
@graphql-tools/load-files Minor
@graphql-tools/apollo-engine-loader Minor
@graphql-tools/code-file-loader Minor
@graphql-tools/git-loader Minor
@graphql-tools/github-loader Minor
@graphql-tools/graphql-file-loader Minor
@graphql-tools/json-file-loader Minor
@graphql-tools/module-loader Minor
@graphql-tools/prisma-loader Minor
@graphql-tools/url-loader Minor
@graphql-tools/merge Minor
@graphql-tools/mock Minor
@graphql-tools/node-require Minor
@graphql-tools/optimize Minor
@graphql-tools/relay-operation-optimizer Minor
@graphql-tools/resolvers-composition Minor
@graphql-tools/schema Minor
@graphql-tools/stitch Minor
@graphql-tools/stitching-directives Minor
@graphql-tools/utils Minor
@graphql-tools/webpack-loader Minor
@graphql-tools/webpack-loader-runtime Minor
@graphql-tools/wrap Minor
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n1ru4l n1ru4l force-pushed the chore-typescript-esm-support branch from c7c2c15 to f9798b9 Compare June 24, 2022 09:57
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 24, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/batch-delegate@8.3.0-alpha-9b9d680a.0
@graphql-tools/batch-execute@8.5.0-alpha-9b9d680a.0
@graphql-tools/delegate@8.8.0-alpha-9b9d680a.0
@graphql-tools/graphql-tag-pluck@7.3.0-alpha-9b9d680a.0
graphql-tools@8.3.0-alpha-9b9d680a.0
@graphql-tools/import@6.7.0-alpha-9b9d680a.0
@graphql-tools/jest-transform@1.2.0-alpha-9b9d680a.0
@graphql-tools/links@8.3.0-alpha-9b9d680a.0
@graphql-tools/load@7.7.0-alpha-9b9d680a.0
@graphql-tools/load-files@6.6.0-alpha-9b9d680a.0
@graphql-tools/apollo-engine-loader@7.3.0-alpha-9b9d680a.0
@graphql-tools/code-file-loader@7.3.0-alpha-9b9d680a.0
@graphql-tools/git-loader@7.2.0-alpha-9b9d680a.0
@graphql-tools/github-loader@7.3.0-alpha-9b9d680a.0
@graphql-tools/graphql-file-loader@7.4.0-alpha-9b9d680a.0
@graphql-tools/json-file-loader@7.4.0-alpha-9b9d680a.0
@graphql-tools/module-loader@7.2.0-alpha-9b9d680a.0
@graphql-tools/prisma-loader@7.2.0-alpha-9b9d680a.0
@graphql-tools/url-loader@7.11.0-alpha-9b9d680a.0
@graphql-tools/merge@8.3.0-alpha-9b9d680a.0
@graphql-tools/mock@8.7.0-alpha-9b9d680a.0
@graphql-tools/node-require@6.4.0-alpha-9b9d680a.0
@graphql-tools/optimize@1.3.0-alpha-9b9d680a.0
@graphql-tools/relay-operation-optimizer@6.5.0-alpha-9b9d680a.0
@graphql-tools/resolvers-composition@6.5.0-alpha-9b9d680a.0
@graphql-tools/schema@8.5.0-alpha-9b9d680a.0
@graphql-tools/stitch@8.7.0-alpha-9b9d680a.0
@graphql-tools/stitching-directives@2.3.0-alpha-9b9d680a.0
@graphql-tools/utils@8.8.0-alpha-9b9d680a.0
@graphql-tools/webpack-loader@6.7.0-alpha-9b9d680a.0
@graphql-tools/webpack-loader-runtime@6.4.0-alpha-9b9d680a.0
@graphql-tools/wrap@8.5.0-alpha-9b9d680a.0

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 238       ✗ 0  
     data_received..................: 28 MB   2.7 MB/s
     data_sent......................: 102 kB  10 kB/s
     http_req_blocked...............: avg=22.82µs  min=2.6µs   med=3.4µs   max=2.29ms   p(90)=4.12µs   p(95)=4.62µs  
     http_req_connecting............: avg=18.88µs  min=0s      med=0s      max=2.24ms   p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=78.93ms  min=68.79ms med=75.4ms  max=161.97ms p(90)=82.26ms  p(95)=118.78ms
       { expected_response:true }...: avg=78.93ms  min=68.79ms med=75.4ms  max=161.97ms p(90)=82.26ms  p(95)=118.78ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 119
     http_req_receiving.............: avg=174.57µs min=142.2µs med=159.6µs max=963.41µs p(90)=176.26µs p(95)=185.65µs
     http_req_sending...............: avg=104.04µs min=17.4µs  med=26.1µs  max=2.88ms   p(90)=29.32µs  p(95)=185.37µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=78.65ms  min=68.58ms med=75.21ms max=160.92ms p(90)=81.59ms  p(95)=118.52ms
     http_reqs......................: 119     11.778493/s
     iteration_duration.............: avg=84.87ms  min=73.62ms med=80.72ms max=169.55ms p(90)=92.34ms  p(95)=123.54ms
     iterations.....................: 119     11.778493/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Jun 24, 2022

@glasser and @trevor-scheer please note the broken deep apollo-client imports: https://github.com/ardatan/graphql-tools/runs/7039823649?check_suite_focus=true You should probably add a proper exports map to apollo-client itself. I had to do this ugly workaround: ff3c071 😢

@glasser
Copy link
Contributor

glasser commented Jun 24, 2022

@n1ru4l thanks, I pointed @benjamn at this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants