Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fixes for TypeScript 4.8 #4673

Merged
merged 2 commits into from Aug 26, 2022

Conversation

thgreasi
Copy link
Contributor

@thgreasi thgreasi commented Aug 26, 2022

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Update the typings so the the package is able to build with TypeScript v4.8 and the tests of the respective bump PR gets fixed.

Related #4674
Related #4672

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-tools/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

🦋 Changeset detected

Latest commit: 5974f9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/jest-transform Patch
@graphql-tools/url-loader Patch
@graphql-tools/utils Patch
@graphql-tools/wrap Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/delegate Patch
@graphql-tools/graphql-tag-pluck Patch
@graphql-tools/import Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
graphql-tools Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 26, 2022

@thgreasi is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 10:15AM (UTC)

@ardatan
Copy link
Owner

ardatan commented Aug 26, 2022

Thanks! Could you create a changeset by using yarn changeset then we can merge and release?

@thgreasi
Copy link
Contributor Author

Hey @ardatan . Should I manually set the name for the change set and should I generate one per package or is it fine to have one for both?

@thgreasi thgreasi force-pushed the update-types-for-ts-4.8 branch 5 times, most recently from d40eb3d to a36b4b3 Compare August 26, 2022 12:16
@ardatan
Copy link
Owner

ardatan commented Aug 26, 2022

This is good! Thanks!

@ardatan ardatan merged commit 4fe3d9c into ardatan:master Aug 26, 2022
@thgreasi thgreasi deleted the update-types-for-ts-4.8 branch August 26, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants