Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new graphql package #4688

Merged
merged 6 commits into from Sep 1, 2022
Merged

create new graphql package #4688

merged 6 commits into from Sep 1, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Aug 31, 2022

we will keep 0.0.x for versioning until we stabilize things we need

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

🦋 Changeset detected

Latest commit: 05d016a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 2:57PM (UTC)

Comment on lines +58 to +69
// TODO: Enable us incrementally
"no-use-before-define": "off",
"@typescript-eslint/prefer-as-const": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/no-inferrable-types": "off",
"unicorn/no-lonely-if": "off",
"@typescript-eslint/no-unused-vars": "off",
"prefer-rest-params": "off",
"no-throw-literal": "off",
"promise/param-names": "off",
"eqeqeq": "off"
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @B2o5T I will improve these in future PRs :)

* @internal
*/
export function printBlockString(value: string, options?: { minimize?: boolean }): string {
const escapedValue = value.replace(/"""/g, '\\"""');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This does not escape backslash characters in the input.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/graphql 0.0.1-alpha-20220901143614-b0dc1ca6 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

❌ Benchmark Failed

Performance regression detected: it seems like your Pull Request adds some extra latency to Schema Stitching

If the performance regression is expected, please increase the failing threshold.

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 176      ✗ 0  
     data_received..................: 21 MB   2.0 MB/s
     data_sent......................: 75 kB   7.5 kB/s
     http_req_blocked...............: avg=7.77µs   min=3µs     med=3.8µs    max=324µs    p(90)=4.89µs   p(95)=5.49µs  
     http_req_connecting............: avg=2.52µs   min=0s      med=0s       max=222.1µs  p(90)=0s       p(95)=0s      
   ✗ http_req_duration..............: avg=107.41ms min=89.47ms med=100.94ms max=221.45ms p(90)=117.33ms p(95)=157.84ms
       { expected_response:true }...: avg=107.41ms min=89.47ms med=100.94ms max=221.45ms p(90)=117.33ms p(95)=157.84ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 88 
     http_req_receiving.............: avg=199.7µs  min=161.4µs med=180.8µs  max=638.5µs  p(90)=235.84µs p(95)=309.35µs
     http_req_sending...............: avg=106.47µs min=18.39µs med=33.09µs  max=2.28ms   p(90)=56.95µs  p(95)=633.12µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=107.11ms min=89.24ms med=100.5ms  max=220.71ms p(90)=116.43ms p(95)=157.57ms
     http_reqs......................: 88      8.757243/s
     iteration_duration.............: avg=114.15ms min=95.12ms med=107.63ms max=227.45ms p(90)=123.18ms p(95)=166.45ms
     iterations.....................: 88      8.757243/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

@saihaj saihaj merged commit 72dadfe into master Sep 1, 2022
@saihaj saihaj deleted the saihaj/new-enginer branch September 1, 2022 14:59
@saihaj saihaj mentioned this pull request Sep 1, 2022
14 tasks
@saihaj saihaj self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants