Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle overlapping fields correctly across subschemas #6091

Merged
merged 4 commits into from Apr 25, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 25, 2024

Read the changeset for the description.
This PR fixes the validation issues within no-entity Federation example

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 0be344e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphql-tools/stitch Minor
@graphql-tools/federation Patch
@graphql-tools/delegate Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 25, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.5-alpha-20240425165952-0be344e2ffe5fcda1f8884271e2843f35a633a93 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.28-alpha-20240425165952-0be344e2ffe5fcda1f8884271e2843f35a633a93 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.0-alpha-20240425165952-0be344e2ffe5fcda1f8884271e2843f35a633a93 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Apr 25, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 336       ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 144 kB  14 kB/s
     http_req_blocked...............: avg=3.96µs   min=2.03µs   med=2.57µs   max=160µs    p(90)=3.96µs   p(95)=4.38µs  
     http_req_connecting............: avg=642ns    min=0s       med=0s       max=107.9µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=55.19ms  min=47.25ms  med=50.72ms  max=177.28ms p(90)=71.13ms  p(95)=86.01ms 
       { expected_response:true }...: avg=55.19ms  min=47.25ms  med=50.72ms  max=177.28ms p(90)=71.13ms  p(95)=86.01ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 168
     http_req_receiving.............: avg=135.59µs min=112.01µs med=129.97µs max=277.48µs p(90)=157.29µs p(95)=162.61µs
     http_req_sending...............: avg=25.51µs  min=17.65µs  med=24.75µs  max=59.69µs  p(90)=31.78µs  p(95)=34.82µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.03ms  min=47.1ms   med=50.56ms  max=176.95ms p(90)=70.95ms  p(95)=85.84ms 
     http_reqs......................: 168     16.733788/s
     iteration_duration.............: avg=59.74ms  min=51.04ms  med=55ms     max=182.6ms  p(90)=75.31ms  p(95)=89.9ms  
     iterations.....................: 168     16.733788/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Apr 25, 2024

💻 Website Preview

The latest changes are available as preview in: https://5b194d94.graphql-tools.pages.dev

@ardatan ardatan merged commit 9bca9e0 into master Apr 25, 2024
30 checks passed
@ardatan ardatan deleted the overlapping-fields branch April 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant