Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Federation Test endpoint and fix parent entity call example #6092

Merged
merged 7 commits into from Apr 25, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 25, 2024

See the changeset for the description.
This PR adds parent-entity-call test case for Federation.

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 58b6dd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/stitch Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/delegate/src/mergeFields.ts Dismissed Show dismissed Hide dismissed
packages/delegate/src/mergeFields.ts Dismissed Show dismissed Hide dismissed
Copy link
Contributor

github-actions bot commented Apr 25, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 348       ✗ 0  
     data_received..................: 41 MB   4.0 MB/s
     data_sent......................: 149 kB  15 kB/s
     http_req_blocked...............: avg=24.56µs  min=2.18µs   med=2.63µs   max=3.77ms   p(90)=3.86µs   p(95)=4.02µs 
     http_req_connecting............: avg=21.27µs  min=0s       med=0s       max=3.7ms    p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=53.67ms  min=45.96ms  med=49.46ms  max=150.23ms p(90)=63.14ms  p(95)=85.91ms
       { expected_response:true }...: avg=53.67ms  min=45.96ms  med=49.46ms  max=150.23ms p(90)=63.14ms  p(95)=85.91ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 174
     http_req_receiving.............: avg=136.05µs min=108.17µs med=133.17µs max=335.25µs p(90)=152.87µs p(95)=159.3µs
     http_req_sending...............: avg=25.58µs  min=15.73µs  med=25.38µs  max=82.46µs  p(90)=29.78µs  p(95)=34.9µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=53.51ms  min=45.8ms   med=49.31ms  max=149.82ms p(90)=62.97ms  p(95)=85.76ms
     http_reqs......................: 174     17.297267/s
     iteration_duration.............: avg=57.78ms  min=49.61ms  med=53.48ms  max=159.47ms p(90)=66.97ms  p(95)=89.98ms
     iterations.....................: 174     17.297267/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Comment on lines 720 to 722
typeMergingOptions: {
useNonNullableFieldOnConflict: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a bit this option?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is the wrong PR. I'll move this commit to the other one

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from overlapping-fields to master April 25, 2024 17:59
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.5-alpha-20240425180058-58b6dd0e11ca66f4ae62e22763d89bcaa0cc6b9b npm ↗︎ unpkg ↗︎
@graphql-tools/federation 1.1.28-alpha-20240425180058-58b6dd0e11ca66f4ae62e22763d89bcaa0cc6b9b npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.0-alpha-20240425180058-58b6dd0e11ca66f4ae62e22763d89bcaa0cc6b9b npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 243c353 into master Apr 25, 2024
29 checks passed
@ardatan ardatan deleted the parent-entity-fields branch April 25, 2024 18:04
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://2b74653a.graphql-tools.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants