Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stitch): do not remove unmerged fields from both isolated and non-isolated subschemas #6105

Merged
merged 7 commits into from Apr 29, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 29, 2024

This PR also adds tests if @graphql-tools/federation gives the expected schema as same as supergraph defines.

See the changesets for the changes

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 552f8ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/stitch Patch
@graphql-tools/utils Minor
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 29, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/stitch 9.2.1-alpha-20240429120433-552f8ab685b2c3e3b462ab0ab019f427a5dfed1f npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.2.0-alpha-20240429120433-552f8ab685b2c3e3b462ab0ab019f427a5dfed1f npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Apr 29, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 310       ✗ 0  
     data_received..................: 36 MB   3.6 MB/s
     data_sent......................: 133 kB  13 kB/s
     http_req_blocked...............: avg=4.8µs    min=2.27µs   med=3.27µs   max=206.33µs p(90)=4.63µs   p(95)=5.16µs  
     http_req_connecting............: avg=868ns    min=0s       med=0s       max=134.64µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=60.53ms  min=52.12ms  med=56.67ms  max=149.12ms p(90)=65.65ms  p(95)=92.74ms 
       { expected_response:true }...: avg=60.53ms  min=52.12ms  med=56.67ms  max=149.12ms p(90)=65.65ms  p(95)=92.74ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 155
     http_req_receiving.............: avg=138.45µs min=110.66µs med=134.66µs max=403.94µs p(90)=155.55µs p(95)=164.62µs
     http_req_sending...............: avg=27.95µs  min=21.48µs  med=27.56µs  max=61.7µs   p(90)=34.01µs  p(95)=36.8µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=60.36ms  min=51.96ms  med=56.51ms  max=148.65ms p(90)=65.47ms  p(95)=92.57ms 
     http_reqs......................: 155     15.453503/s
     iteration_duration.............: avg=64.68ms  min=55.78ms  med=61.08ms  max=154.35ms p(90)=70.51ms  p(95)=96.88ms 
     iterations.....................: 155     15.453503/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Apr 29, 2024

💻 Website Preview

The latest changes are available as preview in: https://ac90c3f6.graphql-tools.pages.dev

@ardatan ardatan merged commit 5567347 into master Apr 29, 2024
29 checks passed
@ardatan ardatan deleted the fix-missing-fields branch April 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant