Pass and Check for Error Extensions

[edorsey]

I was working with Apollo Server 2.0 and I couldn't get my AuthenticationError code of 'UNAUTHENTICATED' to get passed back to the user. https://www.apollographql.com/docs/apollo-server/v2/features/errors.html#Codes

I pin-pointed to here in graphql-tools and it looks like it was originally setup to use result, but not extensions?

Anyway, I copied the test for result and added the logic to make it work for extensions.

TODO:

• If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

[edorsey]

/label bug

[hwillson]

Wow, I'm a bit surprised there haven't been more complaints about this. Thanks very much for tracking this issue down and fixing it @edorsey!

[NicolaiSchmid]

Do you have an estimate, when this change will be published to NPM? Right now it's in the v4 section of the CHANGELOG, and I don't know when that will be finished.
Is there a chance there might be a patch or minor version, publishing this PR sooner?

[hwillson]

@NicolaiSchmid The plan is to release 4.0.0 hopefully on Monday.

[NicolaiSchmid]

Well, that is definitely sooner, than I expected 👍

[cpauls]

Hi @hwillson,
I am waiting for the fix. When do you plan to release? Is there anything I can do?

The plan is to release 4.0.0 hopefully on Monday.

Regards

[hwillson]

@cpauls We're waiting on #953 to be merged. It's almost there, but it needs extra eyes on it due to certain significant changes. As soon as the final review is done, we'll be all set to get 4.0.0 launched. I'm 99% optimistic that it will be ready today (the 1% uncertainty is to accommodate reviewer schedules). Thanks!

[hwillson]

graphql-tools 4.0.0 has been published. Thanks all!