PE-6113: (WIP): add a modal to filter success uploads #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunstmusik
reviewed
May 8, 2024
| enum UploadActions { skip, replace } | ||
| /// | ||
| /// `SkipSuccessfullyUploads` will skip the files that were successfully uploaded. | ||
| enum UploadActions { skip, skipSuccessfullyUploads, replace } |
There was a problem hiding this comment.
prefer to rename to skipSuccessfulUploads or skipExistingFiles
atticusofsparta
previously approved these changes
May 8, 2024
| @@ -3,4 +3,6 @@ | |||
| /// `Skip` Will ignore the files and don't upload them. | |||
| /// | |||
| /// `Replace` will upload the conflicting file and replace the existent. | |||
| enum UploadActions { skip, replace } | |||
| /// | |||
| /// `SkipSuccessfullyUploads` will skip the files that were successfully uploaded. | |||
There was a problem hiding this comment.
nit(grammar):
Suggested change
| /// `SkipSuccessfullyUploads` will skip the files that were successfully uploaded. | |
| /// `SkipSuccessfulUploads` will skip the files that were successfully uploaded. |
|
Visit the preview URL for this PR (updated for commit 3a74153): https://ardrive-web--pr1736-pe-6113-fix-d0tmwm13.web.app (expires Fri, 07 Jun 2024 20:17:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
kunstmusik
reviewed
May 8, 2024
| @@ -333,7 +333,12 @@ void main() { | |||
| const TypeMatcher<UploadPreparationInProgress>(), | |||
| UploadFileConflict( | |||
| areAllFilesConflicting: true, | |||
| conflictingFileNames: const ['${tRootFolderId}1']), | |||
| conflictingFileNames: const [ | |||
| '${tRootFolderId}1' | |||
There was a problem hiding this comment.
Curious, why is there a 1 added here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/3hv9t5ai5r108