Add UNO R4 WiFi basic support #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About the failure of the "Unit Tests" workflow run: We have been seeing a recent increase in these spurious failures caused by intermittent errors while uploading the coverage data to Codecov. The Tooling Team has had success by adding the upload token as suggested in the error message: There is a detailed explanation of our chosen approach in the commit message here: If you think that approach would be appropriate for this project, I will be happy to submit a pull request to make the equivalent change in the "Unit Tests" workflow. |
per1234
added
type: enhancement
Thanks @per1234 that would be perfect! |
|
Memory usage change @ 0969755
Click for full report table
Click for full report CSV |
|
rebased to fix conflicts |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 27 27
Lines 1220 1220
=======================================
Hits 1159 1159
Misses 61 61 |
|
Memory usage change @ 44f92b0
Click for full report table
Click for full report CSV |
csarnataro
reviewed
Jul 6, 2023
src/ArduinoIoTCloudTCP.cpp
Outdated
| @@ -327,6 +327,12 @@ ArduinoIoTCloudTCP::State ArduinoIoTCloudTCP::handle_ConnectMqttBroker() | |||
| reconnection_retry_delay = min(reconnection_retry_delay, static_cast<unsigned long>(AIOT_CONFIG_MAX_RECONNECTION_RETRY_DELAY_ms)); | |||
| _next_connection_attempt_tick = millis() + reconnection_retry_delay; | |||
|
|
|||
| #if defined(ARDUINO_UNOWIFIR4) | |||
| if (String(WiFi.firmwareVersion()) < String("0.2.0")) { | |||
| DEBUG_ERROR("ArduinoIoTCloudTCP::%s In order to connect to Arduino IoT Cloud, WiFI firmware needs to be >= 0.2.0, current %s", __FUNCTION__, WiFi.firmwareVersion()); | |||
There was a problem hiding this comment.
It should read WiFi firmware instead of WiFI firmware (with lowercase i)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To connect to ArduinoIoTCloud WiFi firmware need to be updated. The minimum required version is
0.2.0.Pre release of the firmware is available here: https://github.com/arduino/uno-r4-wifi-usb-bridge/releases/tag/0.2.0
Updater tool for linux, win, macos.
Instructions for flashing the new firmware available here