Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt/retire SquareLine-based example #27

Closed
aliphys opened this issue May 28, 2024 · 3 comments
Closed

Adapt/retire SquareLine-based example #27

aliphys opened this issue May 28, 2024 · 3 comments
Labels
conclusion: declined Will not be worked on topic: documentation Related to documentation for the project type: enhancement Proposed improvement

Comments

@aliphys
Copy link
Contributor

aliphys commented May 28, 2024

As highlighted by @leonardocavagnis in #22:

Cannot port squarelinestudio_lvgl to v9 because SquareLine Studio is no longer compatible with LVGL. It works only with v8 and earlier.

The squarelinestudio_lvgl_v8.ino is no longer relevant and should be adapted/deleted since:

  • It is not part of the examples we want our Users to interact with
  • The code is not expected to compile (and is not included as part of the compile-example.yml workflow)
    env:
    UNIVERSAL_SKETCH_PATHS: |
    - examples/backlight/SimpleBacklight
    - examples/basic/ArduinoLogoDrawing
    - examples/basic/SimpleText
    - examples/camera/display_camera
    - examples/gfx/geometrical-shapes
    - examples/gfx/hello-world
    - examples/gfx/touch-switch
    - examples/imu/accelerometer
    - examples/imu/gyroscope
    - examples/lvgl/bar_lvgl
    - examples/lvgl/button_lvgl
    - examples/lvgl/check_radio_lvgl
    - examples/lvgl/image_lvgl
    - examples/lvgl/imu_orientation
    - examples/lvgl/slider_lvgl
    - examples/microphone/PDMSerialPlotter
    - examples/rgb/SimpleRGB
    - examples/rgb/blink

Possible solutions

Option Positive Negative
Remove Quick and easy fix, reduced future maintenance. No Zendesk tickets mentioning this specific example, so should have minimal affect on Users Library functionality scope reduced
Adapt Retain compatibility with SquareLine Studio Additional effort for a discontinued feature
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels May 28, 2024
@per1234
Copy link

per1234 commented May 28, 2024

I don't have any opinion regarding whether or not the example should be removed. However, it should be noted that SquareLine Studio have stated they do plan to provide LVGL 9.x support:

https://forum.squareline.io/t/q-plans-timeline-for-lvgl-9-observer-support/2782/2

LVGL9 support is planned for the upcoming April release. (And we’d like to support observers in the future.)

The library/core have backwards compatibility with LVGL 8.x, so even at this time when SquareLine Studio is only compatible with LVGL 8.x, it is still possible for users to use this example by simply installing version 8.4.0 of the "lvgl" library.

@per1234 per1234 added type: enhancement Proposed improvement and removed type: imperfection Perceived defect in any part of project labels May 28, 2024
@leonardocavagnis
Copy link
Contributor

I'm agree with @per1234.
Do not retire squarelinestudio_lvgl_v8.ino, we'll do the porting to LVGLv9 when the new SquareLine studio will be release.

@aliphys
Copy link
Contributor Author

aliphys commented May 28, 2024

Thanks for the insight @per1234 and @leonardocavagnis . Closing this issue, and created issue #29 regarding the porting task @leonardocavagnis mentioned.

@aliphys aliphys closed this as completed May 28, 2024
@per1234 per1234 added the conclusion: declined Will not be worked on label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants