Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

IOExpander: add readAll() API #86

Merged
merged 1 commit into from
Jun 8, 2022
Merged

IOExpander: add readAll() API #86

merged 1 commit into from
Jun 8, 2022

Conversation

facchinm
Copy link
Collaborator

@facchinm facchinm requested a review from Rocketct May 31, 2022 15:06
Copy link
Collaborator

@manchoz manchoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Memory usage change @ ee437a6

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 🔺 0 - +128 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Analog_Out
flash
% examples/Analog_Out
RAM for global variables
% examples/Analog_input/Analog_input_0_10V
flash
% examples/Analog_input/Analog_input_0_10V
RAM for global variables
% examples/Analog_input/Analog_input_4_20mA
flash
% examples/Analog_input/Analog_input_4_20mA
RAM for global variables
% examples/Analog_input/Analog_input_NTC
flash
% examples/Analog_input/Analog_input_NTC
RAM for global variables
% examples/CAN/ReadCan
flash
% examples/CAN/ReadCan
RAM for global variables
% examples/CAN/WriteCan
flash
% examples/CAN/WriteCan
RAM for global variables
% examples/Digital_output
flash
% examples/Digital_output
RAM for global variables
% examples/Digital_programmable/CombinedIOExpander
flash
% examples/Digital_programmable/CombinedIOExpander
RAM for global variables
% examples/Digital_programmable/Digital_input
flash
% examples/Digital_programmable/Digital_input
RAM for global variables
% examples/Digital_programmable/GPIO_programmable
flash
% examples/Digital_programmable/GPIO_programmable
RAM for global variables
% examples/Encoders
flash
% examples/Encoders
RAM for global variables
% examples/Ethernet
flash
% examples/Ethernet
RAM for global variables
% examples/RS232
flash
% examples/RS232
RAM for global variables
% examples/RS485_fullduplex
flash
% examples/RS485_fullduplex
RAM for global variables
% examples/RS485_halfduplex
flash
% examples/RS485_halfduplex
RAM for global variables
% examples/RTC
flash
% examples/RTC
RAM for global variables
% examples/RTC_Alarm
flash
% examples/RTC_Alarm
RAM for global variables
% examples/Temp_probes_RTD
flash
% examples/Temp_probes_RTD
RAM for global variables
% examples/Temp_probes_Thermocouples
flash
% examples/Temp_probes_Thermocouples
RAM for global variables
% examples/USB_host
flash
% examples/USB_host
RAM for global variables
%
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 128 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,128,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@Rocketct
Copy link
Contributor

Rocketct commented Jun 6, 2022

Hi guys did you check if the print of the pins is aligned with the headers number views? at last we decide to not include the writeAll?

@pnndra
Copy link
Contributor

pnndra commented Jun 7, 2022

we need to also add the writeAll() API

@Rocketct
Copy link
Contributor

Rocketct commented Jun 7, 2022

ookk so let me check this if work correctly i'll merge and on top of this i'll push the writeAll()

Copy link
Contributor

@Rocketct Rocketct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works fine i'm going to merge it and made the new PR for the write all

@Rocketct Rocketct merged commit a8f1623 into master Jun 8, 2022
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 23, 2022
@per1234 per1234 deleted the readAll branch September 21, 2023 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants