Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and refactor library #27

Merged
merged 37 commits into from Oct 12, 2021
Merged

Cleanup and refactor library #27

merged 37 commits into from Oct 12, 2021

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Oct 11, 2021 •
edited

This fixes #25.

@aentinger
Removing Wire/Serial abstractions since Arduino_ThreadsafeIO will be …
27c8b4f 
…used for that.
@aentinger
Deleting super-fluous/confusing example code.
a65ed03
@aentinger
Providing simple example of shared variable usage.
044bb8f
@aentinger
Rename Shared to Demo_Shared
900d8d7
@aentinger
Replace Blocks demo with Demo_Source_Sink
dd5ee85
@aentinger
Extract implementation of 'Sink' into a separate file.
9cb1c58
@aentinger
Extract implementation of 'Source' into a separate file.
a0d01a3
@aentinger
Extract implementation of 'Shared' into a separate file.
30e2384
@aentinger
Extract static member definition into dedicated cpp file.
68d0a8a
@aentinger
Prefix member variables with '_'
619fa4b
@aentinger
Extract private member function 'execute' into cpp file.
c562750
@aentinger
Extract public Arduino_Threads member function implementation into cp…
dae21a6 
…p file.
@aentinger
Rearrange function definition for better overview.
3730130
@aentinger
Turn setup/loop into pure virtual functions, thereby turning ArduinoT…
c0583ed 
…hreads into an abstract class, preventing accidential instantiation.
@aentinger
A class with virtual functions needs a virtual destructor.
6067040
@aentinger
When terminating a thread, wait for the thread to join before dealloc…
207b4fc 
…ating the class.
@aentinger
Rename 'execute' to 'threadFunc'
ce77408
@aentinger
Providing a default ctor for initializing member variables.
2d9ef0f
@aentinger
Renaming rtos::Thread pointer 't' to '_thread'
661f97c
@aentinger
Replace (leaky) manual memory handling with a smart pointer.
99bc3c6
@aentinger
Cast loop delay to expected type by rtos::ThisThread::sleep_for()
58f451c
@aentinger
Rename _loop_delay to _loop_delay_ms for better clarity on the unit o…
9e44f59 
…f the parameter.
@aentinger
Replace rtos::Queue/MemoryPool with rtos::Mail which contains both in…
e584553 
… one class.
@aentinger
Separate implementation and definition.
83a748d
@aentinger
Make actions during discarding of old data better visible in the code.
048d823
@aentinger
Prefix private member variable 'val' with a '_'
6b25c8c
@aentinger
Reformat for better optical consistency.
fae2eb1
@aentinger
Drop method 'latest' since its indistinguishable from 'peek'
3e4f2ad
@aentinger
Changing return signature of 'peek' to prevent unauthorized manipulat…
3b83891 
…ion of '_val'
@aentinger
Adding license file.
7450577
@aentinger aentinger added the type: enhancement Proposed improvement label Oct 11, 2021
@aentinger aentinger self-assigned this Oct 11, 2021
@aentinger aentinger force-pushed the pretty-the-horse-up branch 3 times, most recently from 93ba9eb to b466d3d Compare October 11, 2021 08:20
@github-actions
Copy link

Memory usage change @ 904ee61

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Demo_Shared
flash		 % examples/Demo_Shared
RAM for global variables		 % examples/Demo_Source_Sink
flash		 % examples/Demo_Source_Sink
RAM for global variables		 %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Demo_Shared<br>flash,%,examples/Demo_Shared<br>RAM for global variables,%,examples/Demo_Source_Sink<br>flash,%,examples/Demo_Source_Sink<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Oct 11, 2021
This was referenced Oct 12, 2021
Closed
Closed
@github-actions
Copy link

Memory usage change @ 3ac5c61

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Demo_Shared_Counter
flash		 % examples/Demo_Shared_Counter
RAM for global variables		 % examples/Demo_Source_Sink_Counter
flash		 % examples/Demo_Source_Sink_Counter
RAM for global variables		 % examples/Demo_Source_Sink_LED
flash		 % examples/Demo_Source_Sink_LED
RAM for global variables		 %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Demo_Shared_Counter<br>flash,%,examples/Demo_Shared_Counter<br>RAM for global variables,%,examples/Demo_Source_Sink_Counter<br>flash,%,examples/Demo_Source_Sink_Counter<br>RAM for global variables,%,examples/Demo_Source_Sink_LED<br>flash,%,examples/Demo_Source_Sink_LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@github-actions
Copy link

Memory usage change @ de2a0d4

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Demo_Shared_Counter
flash		 % examples/Demo_Shared_Counter
RAM for global variables		 % examples/Demo_Source_Sink_Counter
flash		 % examples/Demo_Source_Sink_Counter
RAM for global variables		 % examples/Demo_Source_Sink_LED
flash		 % examples/Demo_Source_Sink_LED
RAM for global variables		 %
arduino:mbed_nano:nano33ble N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Demo_Shared_Counter<br>flash,%,examples/Demo_Shared_Counter<br>RAM for global variables,%,examples/Demo_Source_Sink_Counter<br>flash,%,examples/Demo_Source_Sink_Counter<br>RAM for global variables,%,examples/Demo_Source_Sink_LED<br>flash,%,examples/Demo_Source_Sink_LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@aentinger aentinger marked this pull request as ready for review October 12, 2021 12:18
@aentinger aentinger merged commit 44c2c74 into master Oct 12, 2021
@aentinger aentinger deleted the pretty-the-horse-up branch October 12, 2021 12:18
aentinger added a commit that referenced this pull request Oct 13, 2021
@aentinger
Merge pull request #27 from bcmi-labs/global-local-callbacks
28522d6 
Global local callbacks
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup library to remove redundancies and prepare for launch
2 participants
@aentinger @per1234