Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Portenta H7 FQBN in "Compile Examples" workflow #95

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Correct Portenta H7 FQBN in "Compile Examples" workflow #95

merged 1 commit into from
Jun 21, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 20, 2023

The arduino:mbed_portenta:envie_m4 board definition has been removed from the arduino:mbed_portenta platform. The GitHub Actions workflow's continued use of the non-existent FQBN caused a spurious run failure of the job that covers using the library on the M4 core of the Portenta H7 board:

https://github.com/arduino-libraries/Arduino_Threads/actions/runs/5320038086/jobs/9633283538#step:6:289

Error during build: Error resolving FQBN: board arduino:mbed_portenta@4.0.2:envie_m4 not found

The target core is now configured by a custom board option of the arduino:mbed_portenta:envie_m7 board definition. The FQBN in the workflow are here updated to use that board option.

The `arduino:mbed_portenta:envie_m4` board definition has been removed from the `arduino:mbed_portenta` platform. The
GitHub Actions workflow's continued use of the non-existent FQBN caused a spurious run failure of the job that covers
using the library on the M4 core of the Portenta H7 board:

```
Error during build: Error resolving FQBN: board arduino:mbed_portenta@4.0.2:envie_m4 not found
```

The target core is now configured by a custom board option of the `arduino:mbed_portenta:envie_m7` board definition. The
FQBN in the workflow are hereby updated to use that board option.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Jun 20, 2023
@per1234 per1234 requested a review from aentinger June 20, 2023 13:20
@per1234 per1234 self-assigned this Jun 20, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @per1234 🚀

@aentinger aentinger merged commit 1dd24c9 into arduino-libraries:main Jun 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants