Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggestions from Per's review #16

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

sebromero
Copy link
Contributor

This PR applies @per1234 's suggestions to fix the compile-examples workflow.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Memory usage change @ d4821dd

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash
% extras/tests/TestExisting
RAM for global variables
% extras/tests/TestFileOperations
flash
% extras/tests/TestFileOperations
RAM for global variables
% extras/tests/TestFolderOperations
flash
% extras/tests/TestFolderOperations
RAM for global variables
% extras/tests/TestRepeatedFormatMount
flash
% extras/tests/TestRepeatedFormatMount
RAM for global variables
% extras/tests/TestUnified
flash
% extras/tests/TestUnified
RAM for global variables
% examples/SimpleStorageWriteRead
flash
% examples/SimpleStorageWriteRead
RAM for global variables
% examples/AdvancedUSBInternalOperations
flash
% examples/AdvancedUSBInternalOperations
RAM for global variables
% examples/BackupInternalPartitions
flash
% examples/BackupInternalPartitions
RAM for global variables
%
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this PR's move of additional-sketch-paths from jobs.build.strategy.matrix.include[*] to jobs.build.strategy.matrix.board[*], the property name here:

${{ matrix.additional-sketch-paths }}

must be changed from matrix.additional-sketch-paths to matrix.board.additional-sketch-paths:

            ${{ matrix.board.additional-sketch-paths }}

As a result of the error, the examples/PortentaH7Logger sketch was not compiled as intended during the "arduino:renesas_portenta:portenta_c33" job of the workflow run for this PR:

https://github.com/arduino-libraries/Arduino_UnifiedStorage/actions/runs/6102435682/job/16560908666#logs

You can see from the logs that only the sketches from env.UNIVERSAL_SKETCH_PATHS ended up being compiled.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ 4b05ce9

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash
% extras/tests/TestExisting
RAM for global variables
% extras/tests/TestFileOperations
flash
% extras/tests/TestFileOperations
RAM for global variables
% extras/tests/TestFolderOperations
flash
% extras/tests/TestFolderOperations
RAM for global variables
% extras/tests/TestRepeatedFormatMount
flash
% extras/tests/TestRepeatedFormatMount
RAM for global variables
% extras/tests/TestUnified
flash
% extras/tests/TestUnified
RAM for global variables
% examples/SimpleStorageWriteRead
flash
% examples/SimpleStorageWriteRead
RAM for global variables
% examples/AdvancedUSBInternalOperations
flash
% examples/AdvancedUSBInternalOperations
RAM for global variables
% examples/BackupInternalPartitions
flash
% examples/BackupInternalPartitions
RAM for global variables
% examples/PortentaH7Logger
flash
% examples/PortentaH7Logger
RAM for global variables
%
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%,examples/PortentaH7Logger<br>flash,%,examples/PortentaH7Logger<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,

Copy link
Member

@aliphys aliphys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/compile-examples.yml Show resolved Hide resolved
@aliphys aliphys self-requested a review September 7, 2023 07:57
@sebromero sebromero merged commit d72391f into main Sep 7, 2023
13 checks passed
@sebromero sebromero deleted the compile-workflow-fix branch September 7, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants