-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply suggestions from Per's review #16
Conversation
6bed135
to
d4821dd
Compare
Memory usage change @ d4821dd
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this PR's move of additional-sketch-paths
from jobs.build.strategy.matrix.include[*]
to jobs.build.strategy.matrix.board[*]
, the property name here:
${{ matrix.additional-sketch-paths }} |
must be changed from matrix.additional-sketch-paths
to matrix.board.additional-sketch-paths
:
${{ matrix.board.additional-sketch-paths }}
As a result of the error, the examples/PortentaH7Logger
sketch was not compiled as intended during the "arduino:renesas_portenta:portenta_c33" job of the workflow run for this PR:
You can see from the logs that only the sketches from env.UNIVERSAL_SKETCH_PATHS
ended up being compiled.
Memory usage change @ 4b05ce9
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR applies @per1234 's suggestions to fix the compile-examples workflow.