Handle SMS responses #104
Merged
Handle SMS responses #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed to be more robust. Still minimal code changes, but now the change makes sure that SMS content is ignored altogether. No longer adds a new _atCommandState value. |
aentinger
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the current code will mis-interpret an SMS response for any SMS with the content "OK".
In this case the AT command response will contain "+CMGL: ...\r\nOK\r\n" which will be caught in MODEM::poll() during the readout of the response, and break the interpreter.
The pull request contains special handling of "+CMGL:" responses.
I tried to make the change as small as possible, and with as small runtime overhead as possible. It checks if the response contains an SMS response once, and if not, continues with the old code.